fix: move <LicenseBannerView /> to generic collapse - #28831
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f1a847678
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <CollapsibleTrigger className="text-xs mt-0.5"> | ||
| <Button |
There was a problem hiding this comment.
Make the Button the collapsible trigger
When the banner has at least three messages, this renders nested <button> elements because CollapsibleTrigger defaults to a button and Button renders another button. This creates invalid markup and two keyboard focus stops for one action, and can make the semantic button lookup in the ThreeWarnings story ambiguous. Set asChild on CollapsibleTrigger, as the other Button-backed collapsible triggers do, so the Button itself becomes the single trigger.
AGENTS.md reference: site/AGENTS.md:L12-L12
Useful? React with 👍 / 👎.
This pull-request previously used
<Expander />and was the only calling spot for it. Looks like a really easy way to remove a bespoke component if its the only use-case of<Expander />