Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site/src): repair two stories broken by a11y-name drift #28868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 1 commit into from
Sep 1, 2026
Merged

fix(site/src): repair two stories broken by a11y-name drift #28868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions site/src/modules/dashboard/LicenseBanner/LicenseBannerView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,12 @@ const ExpandableLicenseMessageList: React.FC<{
<LicenseMessageList messages={hiddenMessages} />
</div>
</CollapsibleContent>
<CollapsibleTrigger className="text-xs mt-0.5">
{/* asChild: the trigger must not render its own <button>
around Button, which is invalid HTML and exposes two
identically named buttons to assistive tech. */}
<CollapsibleTrigger asChild>
<Button
className="text-content-primary px-0"
className="text-xs mt-0.5 text-content-primary px-0"
variant="subtle"
size="sm"
>
Expand Down
5 changes: 4 additions & 1 deletion site/src/pages/DeploymentSettingsPage/PremiumPage/TrialRequestForm.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,10 @@ export const KeyboardNavigation: Story = {
canvas.getByRole("combobox", { name: /^Number of developers/ }),
canvas.getByRole("combobox", { name: /^Country/ }),
canvas.getByRole("checkbox"),
canvas.getByRole("link", { name: "Learn more" }),
// The link's accessible name is its aria-label, not its text.
canvas.getByRole("link", {
name: "Learn more about external PostgreSQL databases",
}),
];

for (const element of tabOrder) {
Expand Down
Loading