Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: implement standard IdP sync settings - #28935

Merged
jakehwll merged 13 commits into
mainfrom
jakehwll/idp-sync-cleanup
Sep 10, 2026
Merged

refactor: implement standard IdP sync settings#28935
jakehwll merged 13 commits into
mainfrom
jakehwll/idp-sync-cleanup

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 This PR was written by Coder Agents on behalf of Jake Howell.

Refactors the IdP sync settings pages to use the shared settings patterns and make group and role mapping management clearer. It also separates claim-value loading between the two tabs so each form consistently reflects its configured sync field.

  • reorganizes group and role sync controls into clearer settings sections (standard components)
  • preserves the group and role tabs while loading claim values independently
  • adds a typed confirmation dialog before deleting group mappings
  • consolidates policy export and unseen-claim UI into shared components
idp-sync-group-settings idp-sync-delete-dialog

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@jakehwll
jakehwll marked this pull request as ready for review September 3, 2026 06:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T07:01:49.060757Z cb6487d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderagents

coderagents Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

This PR reorganizes the organization-level IdP Sync group and role settings pages into new SettingsHeader sections and adds a delete-confirmation dialog. The documented steps and field labels in docs/admin/users/idp-sync.md (Group sync field, Regex filter, Auto create missing groups, IdP group name, Coder group, Add IdP group; Role sync field, IdP role name, Coder role, Add IdP role) still match the refactored forms, so no prose changes are required. The embedded screenshots, however, depict these exact pages and no longer reflect the new layout.

Updates Needed

  • docs/admin/users/idp-sync.md - Refresh the group sync screenshots to match the reorganized settings sections: docs/images/admin/users/organizations/group-sync-empty.png and docs/images/admin/users/organizations/group-sync.png. The alt-text for group-sync-empty.png was updated in this PR but the image was not.
  • docs/admin/users/idp-sync.md - Refresh the role sync screenshots to match the reorganized settings sections: docs/images/admin/users/organizations/role-sync-empty.png and docs/images/admin/users/organizations/role-sync.png.

Automated review via Coder Agents

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 3, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb6487d8c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/src/pages/DeploymentSettingsPage/IdpOrgSyncPage/IdpOrgSyncPage.tsx Outdated
Comment thread site/src/modules/idpSync/ExportPolicyButton.stories.tsx Outdated
@jakehwll jakehwll changed the title refactor(site): clean up IdP sync settings refactor: implement standard IdP sync settings Sep 3, 2026
jeremyruppel
jeremyruppel reviewed Sep 4, 2026
View reviewed changes
Comment thread site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx Outdated
jeremyruppel
jeremyruppel reviewed Sep 4, 2026
View reviewed changes
Comment thread site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpRoleSyncForm.tsx Outdated
jeremyruppel
jeremyruppel reviewed Sep 4, 2026
View reviewed changes
Comment thread site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpSyncPage.tsx Outdated
designertyler
designertyler reviewed Sep 9, 2026
View reviewed changes
Comment thread site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx Outdated
@jakehwll
jakehwll merged commit 8a4f2f8 into main Sep 10, 2026
29 checks passed
@jakehwll
jakehwll deleted the jakehwll/idp-sync-cleanup branch September 10, 2026 10:28
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@jeremyruppel jeremyruppel jeremyruppel approved these changes
@designertyler designertyler designertyler approved these changes
@tracyjohnsonux tracyjohnsonux Awaiting requested review from tracyjohnsonux
@chrifro chrifro Awaiting requested review from chrifro
@aslilac aslilac Awaiting requested review from aslilac
@untra untra Awaiting requested review from untra
@DanielleMaywood DanielleMaywood Awaiting requested review from DanielleMaywood DanielleMaywood is a code owner

Assignees

@jakehwll jakehwll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakehwll @jeremyruppel @designertyler