fix: prevent coderd crashes from unsupported Tailnet RPCs (#28429) (conflicts) - #28957
Merged
Conversation
Workspace agents could call RefreshResumeToken and WorkspaceUpdates, even though agent connections do not configure the providers those RPCs require. The resulting nil dereference panicked a DRPC handler and crashed coderd. Limit the agent Tailnet surface to its supported RPCs, return `Unimplemented` when optional providers are absent, and recover panics in Coder-owned DRPC servers so they return an internal error instead of crashing the process. Refs: https://linear.app/codercom/issue/PLAT-464 (cherry picked from commit 156c8b6)
Contributor
|
build-dylib appears to be failing because the Depot macOS runner no longer includes the pinned Xcode 16.1.0; the current run exposes only Xcode 26.x. The release/2.29 branch tip also failed at the “Switch XCode Version” step on August 24, before building the dylibs: https://github.com/coder/coder/actions/runs/32749231024/job/97502334258 An earlier release/2.29 backport run succeeded on July 28, suggesting a Depot change rather than a problem with this backport. |
geokat
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28429
Original PR: #28429 — fix: prevent coderd crashes from unsupported Tailnet RPCs
Merge commit: 156c8b6
Requested by: @geokat
Warning
The automatic cherry-pick had conflicts.
Please resolve manually by cherry-picking the original merge commit: