refactor(coderd/x/chatd): extract runGenerationStep from StartGeneration - #28968
Draft
jscottmiller wants to merge 1 commit into
Draft
refactor(coderd/x/chatd): extract runGenerationStep from StartGeneration#28968jscottmiller wants to merge 1 commit into
jscottmiller wants to merge 1 commit into
Conversation
Move the body of the StartGeneration loop into runGenerationStep, which runs one step of a turn and reports whether the caller must reload state and run another. The loop keeps only state loading and the continue/return decision. Every return path maps one to one onto the previous inline code, so behavior is unchanged.
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the body of the
forloop inStartGenerationintorunGenerationStep, which returns the input for the next step and whether the caller must reload state and run another. Control flow, error wrapping, andcleanup()placement are unchanged; eachcontinuebecomesagain == trueand eachreturnbecomes a return from the step.This is a pure extraction. It gives the next PRs in the stack a function boundary for a per-step deferred span end.
Part of the chatd lifecycle observability stack: 1 extract step · 2 stage tracer · 3 stream stages · 4 provider attempts · 5 turn span · 6 capacity wait · 7 turn accounting · 8 dashboard. Supersedes the experimental branch in #28741.
🤖 This PR was generated by Coder Agents on behalf of @jscottmiller.