chore: rename recorderTranslation to DRPCRecorder - #29133
Merged
Conversation
translationRecorder did not clarify from what calls were being translated, nor to what they were being translated. The new name immediately explains that calls are being recorded over DRPC.
SasSwart
commented
Sep 9, 2026
| ) | ||
|
|
||
| // WrappedRecorder is a convenience struct which implements RecorderClient and resolves a client before calling each method. | ||
| // WrappedRecorder is a convenience struct which implements Recorder and resolves a client before calling each method. |
Contributor
Author
There was a problem hiding this comment.
I suspect the interface used to be called RecorderClient and that the name drifted, leaving this comment out of date. This caused confusion for me, so I brought it back in line with the interface name.
pawbana
approved these changes
Sep 9, 2026
| recorder := aibridge.NewRecorder( | ||
| p.logger.Named("recorder"), | ||
| p.tracer, | ||
| func(clientCtx context.Context) (aibridge.Recorder, error) { |
Contributor
There was a problem hiding this comment.
(since parameters where cleaned up) very nit: I'd extract func to variable
Contributor
Author
There was a problem hiding this comment.
was considering it. will do something like it in a follow up. I still have questions about why we fetch a new client for every call. Once I understand that, I will make the necessary change here.
johnstcn
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old name,
recorderTranslation, did not clarify from what calls were being translated, nor to what they were being translated. The new name,DRPCRecorder, immediately explains that calls are being recorded over DRPC.This was a readability hurdle while trying to investigate touch points for AIGOV-358.
This is the first step towards implementing either a /dev/null-esque recorder or a logging recorder as per the requirements in AIGOV-358.