Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(docs/admin/integrations): note the OAuth2 registered scope enforcement for upgrades - #29144

Merged
BobbyHo merged 5 commits into
mainfrom
docs/plat-482-dcr-scope-upgrade-note
Sep 11, 2026
Merged

docs(docs/admin/integrations): note the OAuth2 registered scope enforcement for upgrades#29144
BobbyHo merged 5 commits into
mainfrom
docs/plat-482-dcr-scope-upgrade-note

Conversation

@BobbyHo

@BobbyHo BobbyHo commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

TL;DR

  • Adds an upgrade note to the OAuth2 provider doc for the compatibility break introduced in feat!: mint access tokens with the negotiated scope #28237.
  • Apps registered through Dynamic Client Registration with a scope outside scopes_supported now fail instead of receiving full access.
  • Docs only. No code change.

Contract change

  • None in this PR. It documents one that already shipped on main.

What it says

  • Only deployments with the oauth2 experiment and Dynamic Client Registration enabled are affected. DCR is disabled by default.
  • Apps registered without a scope, and apps created through the web UI or management API, keep full access.
  • Requests for an unsupported registered name fail with invalid_scope. If nothing registered is supported, every authorization fails. Pre-upgrade codes fail with invalid_grant.
  • Fix: update the registration through RFC 7592 client configuration with the registration access token, or register again. Admins cannot edit the value.

Docs


Closes the release note item in PLAT-482.

🤖 Generated with Claude Code

@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown

PLAT-482

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@BobbyHo BobbyHo changed the title docs(admin/integrations): note the OAuth2 registered scope enforcement for upgrades docs(docs/admin/integrations): note the OAuth2 registered scope enforcement for upgrades Sep 9, 2026
@BobbyHo
BobbyHo marked this pull request as ready for review September 9, 2026 19:53

Copy link
Copy Markdown
Contributor

Could we include deployments that previously enabled DCR and have since turned it off? Turning it off only blocks new registrations; an existing client registered with openid profile email still fails authorization after the upgrade because its stored scopes are checked regardless of that setting. The current wording makes that deployment sound unaffected. Saying this applies to previously registered clients, even with DCR now off, would cover that case.

docs/admin/integrations/oauth2-provider.md:654

…s turned off

The upgrade note said registered scope enforcement only affects deployments
with Dynamic Client Registration turned on. The setting gates registration
only. The stored scope of an existing application is checked on every
authorization regardless, so a client registered while DCR was on remains
affected after it is turned off.

Refs PLAT-482

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content and accuracy hold up here: the fix endpoint, the "who's affected" logic, and the previously raised DCR-toggle case all check out. The one thing working against the note is readability. It's a single dense paragraph carrying about six ideas at once, and the opening sentence is ambiguous about who registers the application (the client self-registers; no admin sets the scope).

The inline suggestion keeps every fact but restructures it, following the docs style guide: one sentence per source line, "refer to" instead of "see," a short list for the failure modes, and an explicit actor so "registered" can't be misread as an admin action. It also links the existing Common Issues entries so the error detail isn't restated in two places. Non-blocking, take or leave any of it.

Posted by Coder Agents on behalf of @nickvigilante.

Comment thread docs/admin/integrations/oauth2-provider.md Outdated

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you don't mind I came in and reviewed this, but it overall LGTM with some rearranging and breaking up of the giant paragraph. Thanks for writing this up!

@BobbyHo

BobbyHo commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Hope you don't mind I came in and reviewed this, but it overall LGTM with some rearranging and breaking up of the giant paragraph. Thanks for writing this up!

Thank you @nickvigilante for reviewing this PR and sharing your suggestion — really appreciate it!

@BobbyHo
BobbyHo merged commit 0a764d7 into main Sep 11, 2026
29 checks passed
@BobbyHo
BobbyHo deleted the docs/plat-482-dcr-scope-upgrade-note branch September 11, 2026 16:09
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants