chore(site/.oxlintrc.jsonc): enable oxlint anchor-ambiguous-text rule - #29191
Merged
Conversation
jeremyruppel
marked this pull request as ready for review
September 10, 2026 19:10
jeremyruppel
added this pull request to stack #29193
September 10, 2026 20:07
aqandrew
approved these changes
Sep 10, 2026
jeremyruppel
added a commit
that referenced
this pull request
Sep 10, 2026
Enables the `role-supports-aria-props` oxlint rule (jsx-a11y), moving it out of the migration backlog and setting it to `error`. Stacked on top of #29191. Review that PR first; the base of this PR is its branch. ## Fixes for the two violations the rule surfaced - **`Autocomplete.tsx` (select-only trigger button):** removed `aria-invalid` from the `<button>`. `aria-invalid` is not exposed by the implicit `button` role, so it had no effect for assistive tech. The error message linkage via `aria-describedby` (a global attribute) is kept. The only consumer that sets an invalid state (`ModelIdentifierField`) uses the `inlineSearch` variant, which renders an `<input role="combobox">` that still keeps `aria-invalid` (valid there). - **`AgentLatency.tsx` (latency popover trigger):** the trigger was a `<span role="presentation" aria-label="latency">`; `presentation` does not support `aria-label`, and a presentational role on an interactive trigger is wrong. Converted it to a real `<button>` with reset styling so it stays visually identical (inline colored text, no button chrome) while being a focusable, correctly-labeled control. ## Verification - `oxlint --deny-warnings`: 0 warnings, 0 errors. - `biome lint --error-on-warnings` on the changed files: clean. - `tsc -p .`: clean. - Storybook visual check of `components/AgentRow --example`: latency renders as inline colored text (no boxed button) and clicking it still opens the "Latency" popover. --- _This PR was generated by Coder Agents on behalf of @jeremyruppel._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
anchor-ambiguous-textoxlint rule (jsx-a11y), moving it out of the migration backlog and setting it toerror.The codebase already has zero violations, so no code changes were needed. Verified with
oxlint --deny-warnings(0 warnings, 0 errors) and confirmed the rule is active by testing it against a known-bad<a>click here</a>sample.Per request, the corresponding Biome rule (
a11y/noAmbiguousAnchorText) is intentionally left enabled for now so both linters double-check this.This PR was generated by Coder Agents on behalf of @jeremyruppel.