Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(site): enable oxlint role-supports-aria-props rule #29192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyruppel merged 2 commits into from
Sep 10, 2026
+4 −5
Merged

chore(site): enable oxlint role-supports-aria-props rule #29192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1583e9
chore(site): enable oxlint role-supports-aria-props rule
jeremyruppel Sep 10, 2026
b6f5622
chore(site/src/modules/resources/AgentLatency.tsx): drop redundant bu…
jeremyruppel Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/.oxlintrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"img-redundant-alt": "error",
"no-redundant-roles": "error",
"role-has-required-aria-props": "error",
"role-supports-aria-props": "error",
"alt-text": "error",
"anchor-has-content": "error",
"anchor-ambiguous-text": "error",
Expand Down Expand Up @@ -207,7 +208,6 @@
"consistent-type-imports": "off", // style/useImportType (medium)
"jsx-curly-brace-presence": "off", // style/useConsistentCurlyBraces (medium, coder error rule)
"no-fallthrough": "off", // suspicious/noFallthroughSwitchClause (medium)
"role-supports-aria-props": "off", // a11y/useAriaPropsSupportedByRole (small)
"click-events-have-key-events": "off", // a11y/useKeyWithClickEvents (small)
"prefer-function-type": "off", // style/useShorthandFunctionType (small)
"no-empty-interface": "off", // suspicious/noEmptyInterface (small)
Expand Down
1 change: 0 additions & 1 deletion site/src/components/Autocomplete/Autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ export function Autocomplete<TOption>({
data-testid={testId}
aria-expanded={isOpen}
aria-haspopup="listbox"
aria-invalid={triggerAriaInvalid}
aria-describedby={triggerAriaDescribedBy}
disabled={disabled}
className={cn(
Expand Down
6 changes: 3 additions & 3 deletions site/src/modules/resources/AgentLatency.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ export const AgentLatency: FC<AgentLatencyProps> = ({ agent }) => {
return (
<HelpPopover>
<HelpPopoverTrigger asChild>
<span
role="presentation"
<button
type="button"
aria-label="latency"
className={cn("cursor-pointer", latency.color)}
>
{Math.round(latency.latency_ms)}ms
</span>
</button>
</HelpPopoverTrigger>
<HelpPopoverContent>
<HelpPopoverTitle>Latency</HelpPopoverTitle>
Expand Down
Loading