Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(site): enable consistent-type-imports oxlint rule #29254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aqandrew merged 2 commits into from
Sep 11, 2026
+11 −7
Merged

chore(site): enable consistent-type-imports oxlint rule #29254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e932a21
chore: set consistent-type-imports rule to error
aqandrew Sep 11, 2026
16a56b4
refactor: import types with static declarations instead of dynamic im…
aqandrew Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/.oxlintrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@
// --- style (recommended) ---
"no-array-constructor": "error",
"prefer-exponentiation-operator": "error",
"consistent-type-imports": "error",
"consistent-type-exports": "error",
"prefer-literal-enum-member": "error",
"prefer-node-protocol": "error",
Expand Down Expand Up @@ -206,7 +207,6 @@
"no-redeclare": "off", // suspicious/noRedeclare (medium: TS declaration merging)
"no-irregular-whitespace": "off", // suspicious/noIrregularWhitespace (medium)
"no-inferrable-types": "off", // style/noInferrableTypes (medium, coder error rule)
"consistent-type-imports": "off", // style/useImportType (medium)
"jsx-curly-brace-presence": "off", // style/useConsistentCurlyBraces (medium, coder error rule)
"no-fallthrough": "off", // suspicious/noFallthroughSwitchClause (medium)
"click-events-have-key-events": "off", // a11y/useKeyWithClickEvents (small)
Expand Down
4 changes: 3 additions & 1 deletion site/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { StorybookConfig } from "@storybook/react-vite";

export default {
stories: ["../src/**/*.stories.tsx"],

Expand Down Expand Up @@ -32,4 +34,4 @@ export default {
};
return config;
},
} satisfies import("@storybook/react-vite").StorybookConfig;
} satisfies StorybookConfig;
9 changes: 5 additions & 4 deletions site/src/pages/AgentsPage/components/ChatConversation/useChatStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ import {
} from "#/api/queries/chats";
import type * as TypesGen from "#/api/typesGenerated";
import type { OneWayMessageEvent } from "#/utils/OneWayWebSocket";
import { createReconnectingWebSocket } from "#/utils/reconnectingWebSocket";
import {
createReconnectingWebSocket,
type ReconnectSchedule,
} from "#/utils/reconnectingWebSocket";
import { type ChatDetailError, normalizeChatErrorPayload } from "./chatError";
import {
type ChatStore,
Expand Down Expand Up @@ -743,9 +746,7 @@ export const useChatStore = (
historyResetPending = false;
historyReplacementBuf.length = 0;
},
onDisconnect(
reconnectState: import("#/utils/reconnectingWebSocket").ReconnectSchedule,
) {
onDisconnect(reconnectState: ReconnectSchedule) {
// Only surface reconnecting when the disconnect
// interrupted active response work. Idle watcher
// reconnects stay silent.
Expand Down
3 changes: 2 additions & 1 deletion site/src/pages/AgentsPage/components/ChatElements/tools/Tool.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { chatModelKey } from "#/api/queries/chats";
import { workspaceBuildLogs } from "#/api/queries/workspaceBuilds";
import { workspaceByIdKey } from "#/api/queries/workspaces";
import type * as TypesGen from "#/api/typesGenerated";
import type { MCPServerConfig } from "#/api/typesGenerated";
import { MockChatModel } from "#/testHelpers/chatModels";
import { MockWorkspace, MockWorkspaceBuild } from "#/testHelpers/entities";
import { ChatWorkspaceContext } from "../../../context/ChatWorkspaceContext";
Expand Down Expand Up @@ -1364,7 +1365,7 @@ const sampleMCPServers = [
created_at: "2025-01-01T00:00:00Z",
updated_at: "2025-01-01T00:00:00Z",
},
] satisfies readonly import("#/api/typesGenerated").MCPServerConfig[];
] satisfies MCPServerConfig[];

export const MCPToolRunning: Story = {
args: {
Expand Down
Loading