feat(provisioner/terraform): parse and resolve script order selectors - #29260
Open
geokat wants to merge 1 commit into
Open
feat(provisioner/terraform): parse and resolve script order selectors#29260geokat wants to merge 1 commit into
geokat wants to merge 1 commit into
Conversation
Add package-private helpers to parse script and whole-module selectors, resolve them relative to their declaring module, and expand count, for_each, and nested module instances. Distinguish declared module calls with no concrete scripts from unknown module selectors using Terraform plan configuration. These helpers are not yet wired into workspace provisioning. Selector parsing uses go-terraform-address in this PR. A follow-up replaces it with HCL traversal parsing because go-terraform-address rejects valid Unicode identifiers. Keeping that correction separate limits this PR's scope. Refs: https://linear.app/codercom/issue/PLAT-543
geokat
added this pull request to stack #29262
September 12, 2026 00:14
geokat
marked this pull request as ready for review
September 12, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add package-private helpers to parse script and whole-module
selectors, resolve them relative to their declaring module, and expand
count, for_each, and nested module instances.
Distinguish declared module calls with no concrete scripts from
unknown module selectors using Terraform plan configuration. These
helpers are not yet wired into workspace provisioning.
Selector parsing uses
go-terraform-addressin this PR. #29261replaces it with HCL traversal parsing because
go-terraform-addressrejects valid Unicode identifiers. Keeping that correction separate
limits this PR's scope.
Refs:
https://linear.app/codercom/issue/PLAT-543