fix(provisioner/terraform): support Unicode Terraform addresses - #29261
Open
geokat wants to merge 1 commit into
Open
Conversation
Replace go-terraform-address in script-order selector resolution with HCL traversal parsing. The former accepts only ASCII identifiers and rejects valid Terraform addresses containing Unicode identifiers. Parse the managed-resource addresses and module-instance paths needed by the provisioner, including count and for_each instance keys. Add coverage for Unicode identifiers, nested modules, escaped keys, and invalid address forms. The existing convertAddressToModulePath telemetry helper also uses go-terraform-address and has the same Unicode limitation. Keep that unrelated call path unchanged here to limit scope; it can migrate to this parser separately. Refs: https://linear.app/codercom/issue/PLAT-543
geokat
added this pull request to stack #29262
September 12, 2026 00:14
geokat
marked this pull request as ready for review
September 12, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
go-terraform-addressin script-order selector resolution withHCL traversal parsing. The former accepts only ASCII identifiers and
rejects valid Terraform addresses containing Unicode identifiers.
Parse the managed-resource addresses and module-instance paths needed
by the provisioner, including count and for_each instance keys. Add
coverage for Unicode identifiers, nested modules, escaped keys, and
invalid address forms.
The existing
convertAddressToModulePathtelemetry helper also usesgo-terraform-addressand has the same Unicode limitation. Keep thatunrelated call path unchanged here to limit scope; it can migrate to
this parser separately.
Refs:
https://linear.app/codercom/issue/PLAT-543