Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(site): enable no-redeclare oxlint rule #29263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aqandrew wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(site): enable no-redeclare oxlint rule #29263

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33d777c
chore(site): enable no-redeclare oxlint rule
aqandrew Sep 12, 2026
0fbd855
style: format
aqandrew Sep 12, 2026
e6f5573
fix: update reference to Notification type
aqandrew Sep 12, 2026
d0774b2
style: format imports
aqandrew Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(site): enable no-redeclare oxlint rule
  • Loading branch information
@aqandrew
aqandrew committed Sep 12, 2026
commit 33d777cf97774cebc543c47484f4e532edcf9680
2 changes: 1 addition & 1 deletion site/.oxlintrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@
"new-for-builtins": "error",
"no-explicit-any": "error",
"no-irregular-whitespace": "error",
"no-redeclare": "error",
"no-use-before-define": [
"error",
{ "functions": false, "classes": false, "variables": false }
Expand All @@ -205,7 +206,6 @@
// ==========================================================
"no-autofocus": "off", // a11y/noAutofocus (large)
"no-invalid-void-type": "off", // suspicious/noConfusingVoidType (large)
"no-redeclare": "off", // suspicious/noRedeclare (medium: TS declaration merging)
"no-inferrable-types": "off", // style/noInferrableTypes (medium, coder error rule)
"jsx-curly-brace-presence": "off", // style/useConsistentCurlyBraces (medium, coder error rule)
"no-fallthrough": "off", // suspicious/noFallthroughSwitchClause (medium)
Expand Down
5 changes: 3 additions & 2 deletions site/src/components/FullPageLayout/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,12 @@ export const SidebarCaption: FC<HTMLAttributes<HTMLSpanElement>> = (props) => {
);
};

interface SidebarIconButton extends ComponentProps<typeof TopbarIconButton> {
interface SidebarIconButtonProps
extends ComponentProps<typeof TopbarIconButton> {
isActive: boolean;
}

export const SidebarIconButton: FC<SidebarIconButton> = ({
export const SidebarIconButton: FC<SidebarIconButtonProps> = ({
isActive,
className,
...buttonProps
Expand Down
4 changes: 2 additions & 2 deletions site/src/components/HelpPopover/HelpPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,12 @@ export const HelpPopoverText: FC<HTMLAttributes<HTMLParagraphElement>> = ({
);
};

interface HelpPopoverLink {
interface HelpPopoverLinkProps {
children?: ReactNode;
href: string;
}

export const HelpPopoverLink: FC<HelpPopoverLink> = ({ children, href }) => {
export const HelpPopoverLink: FC<HelpPopoverLinkProps> = ({ children, href }) => {
return (
<a
href={href}
Expand Down
4 changes: 2 additions & 2 deletions site/src/components/MultiUserSelect/MultiUserSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const MultiMemberSelect: FC<MemberAutocompleteProps> = ({
);
};

type UsersTable<T extends SelectedUser> = {
type UsersTableProps<T extends SelectedUser> = {
error: unknown;
onChange: (user: T, checked: boolean) => void;
selected: readonly T[];
Expand All @@ -95,7 +95,7 @@ const UsersTable = <T extends SelectedUser>({
onChange,
selected,
users,
}: UsersTable<T>) => {
}: UsersTableProps<T>) => {
if (error) {
return (
<div className="p-3">
Expand Down
4 changes: 2 additions & 2 deletions site/src/components/Timeline/TimelineDateRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { TableCell, TableRow } from "#/components/Table/Table";
import { formatDate } from "#/utils/time";
import { createDisplayDate } from "./utils";

export interface TimelineDateRow {
interface TimelineDateRowProps {
date: Date;
}

export const TimelineDateRow: FC<TimelineDateRow> = ({ date }) => {
export const TimelineDateRow: FC<TimelineDateRowProps> = ({ date }) => {
return (
<TableRow>
<TableCell
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const validationSchema = Yup.object({
cors_behavior: Yup.string().oneOf(Object.values(CORSBehaviors)),
});

export interface TemplateSettingsForm {
interface TemplateSettingsFormProps {
template: Template;
onSubmit: (data: UpdateTemplateMeta) => void;
onCancel: () => void;
Expand All @@ -79,7 +79,7 @@ export interface TemplateSettingsForm {
portSharingControlsEnabled: boolean;
}

export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
export const TemplateSettingsForm: FC<TemplateSettingsFormProps> = ({
template,
onSubmit,
onCancel,
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateScheduleForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const FAILURE_CLEANUP_DEFAULT = 7 * MS_DAY_CONVERSION;
const INACTIVITY_CLEANUP_DEFAULT = 180 * MS_DAY_CONVERSION;
const DORMANT_AUTODELETION_DEFAULT = 30 * MS_DAY_CONVERSION;

export interface TemplateScheduleForm {
interface TemplateScheduleFormProps {
template: Template;
onSubmit: (data: UpdateTemplateMeta) => void;
onCancel: () => void;
Expand All @@ -72,7 +72,7 @@ export interface TemplateScheduleForm {
initialTouched?: FormikTouched<UpdateTemplateMeta>;
}

export const TemplateScheduleForm: FC<TemplateScheduleForm> = ({
export const TemplateScheduleForm: FC<TemplateScheduleFormProps> = ({
template,
onSubmit,
onCancel,
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/TemplateSettingsPage/TemplateVariablesPage/TemplateVariablesForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
TemplateVariableField,
} from "./TemplateVariableField";

export interface TemplateVariablesForm {
interface TemplateVariablesFormProps {
templateVersion: TemplateVersion;
templateVariables: TemplateVersionVariable[];
onSubmit: (data: CreateTemplateVersionRequest) => void;
Expand All @@ -31,7 +31,7 @@ export interface TemplateVariablesForm {
// Helpful to show field errors on Storybook
initialTouched?: FormikTouched<CreateTemplateVersionRequest>;
}
export const TemplateVariablesForm: FC<TemplateVariablesForm> = ({
export const TemplateVariablesForm: FC<TemplateVariablesFormProps> = ({
templateVersion,
templateVariables,
onSubmit,
Expand Down
6 changes: 3 additions & 3 deletions site/src/pages/WorkspacePage/WorkspaceNotifications/Notifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
} from "#/components/Popover/Popover";
import type { ThemeRole } from "#/theme/roles";

export type NotificationItem = {
type Notification = {
title: string;
severity: AlertProps["severity"];
detail?: ReactNode;
Expand All @@ -20,7 +20,7 @@ export type NotificationItem = {
type NotificationSeverity = "warning" | "info";

type NotificationsProps = {
items: NotificationItem[];
items: Notification[];
severity: NotificationSeverity;
icon: ReactNode;
};
Expand Down Expand Up @@ -131,7 +131,7 @@ const NotificationPill: FC<NotificationPillProps> = ({
};

interface NotificationItemProps {
notification: NotificationItem;
notification: Notification;
}

const NotificationItem: FC<NotificationItemProps> = ({ notification }) => {
Expand Down
Loading