Thanks to visit codestin.com
Credit goes to github.com

Skip to content

agent: Don't set GIT_* environment variables #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dwahler wants to merge 2 commits into from
Closed

agent: Don't set GIT_* environment variables #2980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ad97b0
agent: Don't set GIT_* environment variables
dwahler Jul 13, 2022
3e776d1
Remove owner_email and owner_username fields from agent metadata
dwahler Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
agent: Don't set GIT_* environment variables 
These variables take precedence over settings in the user's .gitconfig, which leads to surprising behavior.
  • Loading branch information
@dwahler
dwahler committed Jul 13, 2022
commit 4ad97b03cd99d833e1d3fbc6e524fae2fe8acd8f
6 changes: 0 additions & 6 deletions agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,6 @@ func (a *agent) createCommand(ctx context.Context, rawCommand string, env []stri
// If using backslashes, it's unable to find the executable.
unixExecutablePath := strings.ReplaceAll(executablePath, "\\", "/")
cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_SSH_COMMAND=%s gitssh --`, unixExecutablePath))
// These prevent the user from having to specify _anything_ to successfully commit.
// Both author and committer must be set!
cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_AUTHOR_EMAIL=%s`, metadata.OwnerEmail))
cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_COMMITTER_EMAIL=%s`, metadata.OwnerEmail))
cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_AUTHOR_NAME=%s`, metadata.OwnerUsername))
cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_COMMITTER_NAME=%s`, metadata.OwnerUsername))

// Load environment variables passed via the agent.
// These should override all variables we manually specify.
Expand Down