Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add template version creator #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 15, 2022
Merged

feat: add template version creator #3001

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73932da
feat: add template version creator
AbhineetJain Jul 14, 2022
e032275
rename method
AbhineetJain Jul 14, 2022
4dcde2f
use the right database
AbhineetJain Jul 14, 2022
c98f87b
wrap migration for a single txn
AbhineetJain Jul 15, 2022
08b6b5d
remove scoping from migration
AbhineetJain Jul 15, 2022
202421e
make template version created_by nullable
AbhineetJain Jul 15, 2022
c8d0d45
use nullable created_by
AbhineetJain Jul 15, 2022
c017a30
fix unit tests
AbhineetJain Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make template version created_by nullable
  • Loading branch information
@AbhineetJain
AbhineetJain committed Jul 15, 2022
commit 202421e330273e0eea314b5504d171ac289fe834
2 changes: 0 additions & 2 deletions coderd/database/migrations/000030_template_version_created_by.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,4 @@ SET
WHERE
created_by IS NULL;

ALTER TABLE ONLY template_versions ALTER COLUMN created_by SET NOT NULL;

COMMIT;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwahler I am hoping wrapping it in BEGIN-COMMIT would help to fix the problem caused by the migration. Not really sure if this broke the server though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, make gen is failing with:

panic: reached retry deadline
goroutine 1 [running]:
main.main()
	/home/runner/work/coder/coder/coderd/database/dump/main.go:19 +0x80c
exit status 2
make: *** [Makefile:60: coderd/database/dump.sql] Error 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the bug, the scoping logic was not good.