fix: set a failed canceled job status correctly #3061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are starting to run into test flakes due to lack of randomness in CI, this change simply bumps randomness by additional suffix numbers. See: #3038 (comment)
* chore: Speed up port-forward tests * chore: Add t.Helper and ensure listener closure on error
Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.9.0 to 1.9.2. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.9.0...v1.9.2) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Related issue: #2122
Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: Fix statuses breaking line in the UI * fix: AppLink stories
Considering database load and CI performance during testing, we should avoid failing too early.
Avoid relying on codecov to manage action step failure, hopefully works around: codecov/codecov-action#788
The Go test timeout uses 20m, if we want to get a stack trace, we must allow the actions worker to run longer than that.
Kira-Pilot
commented
Jul 20, 2022
Kira-Pilot
commented
Jul 20, 2022
johnstcn
reviewed
Jul 21, 2022
Co-authored-by: Cian Johnston <[email protected]>
* fix: Potential deadlock in peer.Channel dc.OnOpen * fix: Potential send on closed channel * fix: Improve robustness of waitOpened during close * chore: Simplify statements * fix: Improve teardown and timeout of peer tests * fix: Improve robustness of TestConn/Buffering test * Update peer/channel.go Co-authored-by: Steven Masley <[email protected]>
Two coderd unit tests (TestPatchCancelTemplateVersion/Success and TestPatchCancelWorkspaceBuild) implied erroneously that the job was canceled successfully. This is not the case, as these unit tests do not include a Provision_Complete response in the input to the echo provisioner. Now explicitly checking the job error and bumping the force cancel interval to be longer. Fixes #3083.
johnstcn
reviewed
Jul 21, 2022
Co-authored-by: Cian Johnston <[email protected]>
Co-authored-by: Cian Johnston <[email protected]>
|
Wow, what a rebase effort. Closing in favor of a cleaner #3101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1374
When a previous job was canceled and that cancellation was unsuccessful, we incorrectly set the job status as
canceled. This fix remedies that issue by setting the status asFailed.