fix: Statuses breaking line in the UI #3071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Jul 20, 2022
jsjoeio
approved these changes
Jul 20, 2022
Kira-Pilot
reviewed
Jul 20, 2022
| @@ -79,7 +79,9 @@ export const BuildsTable: FC<BuildsTableProps> = ({ builds, className }) => { | |||
| </span> | |||
| </TableCellLink> | |||
| <TableCellLink to={buildPageLink}> | |||
| <span style={{ color: status.color }}>{status.status}</span> | |||
| <span style={{ color: status.color }} className={styles.status}> | |||
There was a problem hiding this comment.
Now that this has a class, we can move the inline style into that class.
There was a problem hiding this comment.
It is inline because it is dynamic and passed from the props.
There was a problem hiding this comment.
we can still pass it i think, but nbd if you want to leave it inline!
|
@kylecarbs these changes are not related to the Discord ones. It only avoids the status icon and the "verb" getting split into two lines on small viewports. |
|
@jsjoeio totally, since it was just a tiny small thing I skipped, but I will do it next time, my bad. |
|
@BrunoQuaresma ahh my bad, I just assumed 🙈 |
Kira-Pilot
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1982