Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: avoid emitting version warning when connection error encountered #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Jul 20, 2022

This PR address concerns from comment #3053 (review)

@sreya sreya requested a review from mafredri July 20, 2022 21:49
@sreya sreya requested a review from a team as a code owner July 20, 2022 21:59
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE ✅

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏻

@sreya sreya merged commit e019058 into main Jul 21, 2022
@sreya sreya deleted the jon/fixcheckerrornoise branch July 21, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants