feat: New static error summary component #3107
Conversation
|
|
||
| return ( | ||
| <Stack> | ||
| <Stack className={styles.root}> |
There was a problem hiding this comment.
Does this outermost element need to be a Stack or can it just be a fragment, i.e. <></>?
There was a problem hiding this comment.
Adds the gap for the retry component. I am fine with keeping this as a Stack.
There was a problem hiding this comment.
Refactored it now!
| const useStyles = makeStyles<Theme, StyleProps>((theme) => ({ | ||
| root: { | ||
| background: `${theme.palette.error.main}60`, | ||
| margin: `${theme.spacing(2)}px`, |
There was a problem hiding this comment.
Just a suggestion: this component might be a little more flexible if we leave off the margin and instead let the parent decide what the margin should be (it will probably vary). If you feel like it, you could even pass in a style prop so that the parent can pass through its own styles.
There was a problem hiding this comment.
I think we're going to use this component a lot and I'd like it to look decent without additional styling. Maybe we can give it margins we think are typical and then override when necessary.
This PR repurposes the existing ErrorSummary component to create a static component to display error messages with details from the backend.
We want to make the details section collapsible and the error summary optionally dismissible.
Subtasks
Fixes #3106
Screenshots
Dismissible
Collapsed details
With details