fix: Add a slightly better error message for dropped SSH connection #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Jul 22, 2022
cli/ssh.go
Outdated
| @@ -35,6 +36,8 @@ import ( | |||
| var workspacePollInterval = time.Minute | |||
| var autostopNotifyCountdown = []time.Duration{30 * time.Minute} | |||
|
|
|||
| var errConnectionDropped = xerrors.New("SSH connection ended unexpectedly") | |||
There was a problem hiding this comment.
I think we could inline this for now until it needs to be used elsewhere!
There was a problem hiding this comment.
Another point for inlining: it produces a stacktrace, otherwise we have to wrap the error to get a stack trace.
mafredri
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an SSH connection drops, we typically get an
ssh.ExitMissingErrorfrom the client, which doesn't have a very user-friendly error message:wait: remote command exited without exit status or exit signalThis PR looks for that error type and replaces it with message that, while not necessarily more helpful, at least doesn't incorrectly state the problem is on the remote side:
SSH connection ended unexpectedlyPartial fix for #1369