feat: showcase workspace state in actions dropdown #3133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhineetJain
suggested changes
Jul 25, 2022
site/src/components/WorkspaceActionButton/WorkspaceActionButton.tsx
Outdated
Show resolved
Hide resolved
site/src/components/WorkspaceActions/DropdownContent/DropdownContent.stories.tsx
Outdated
Show resolved
Hide resolved
AbhineetJain
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2020
I strayed from the mock a little bit - I think having the cancel button next to the dropdown button could look jumpy as state transitioned. No worries - there should not be any secondary actions on a cancel anyway, so it's safe to hide this element.