fix: Disable telemetry by default in tests #3200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telemetry reporting for coder server tests were slowing down the tests by ~60x using `-race` (100s vs 1.5s on my machine). Arguably, we should make this change even if it didn't speed up the tests. I also noticed we don't have `goleak` enabled for CLI tests, this commit adds it, but commented out. The reason being that we're nowhere near being able to enable it yet.
|
Whoops, forgot to call |
johnstcn
reviewed
Jul 26, 2022
johnstcn
reviewed
Jul 26, 2022
johnstcn
approved these changes
Jul 26, 2022
Co-authored-by: Cian Johnston <[email protected]>
Emyrk
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry reporting for coder server tests were slowing down the testsby 60x using
-race(100s vs 1.5s on my machine).Arguably, we should make this change even if it didn't speed up thetests.
Edit: I thought this was more impressive but I should've been more suspicious, with
TestMainpresent andgoleakdisabled we were not callingm.Run().Still a change we should make IMO.
I also noticed we don't have
goleakenabled for CLI tests, this commitadds it, but commented out. The reason being that we're nowhere near
being able to enable it yet.