Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: error messages from workspaceScheduleXService #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 28, 2022
Merged

fix: error messages from workspaceScheduleXService #3255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ec4914d
Update color palette
presleyp Jul 27, 2022
cfe1cb1
Edit dialog error colors
presleyp Jul 27, 2022
3838756
Format
presleyp Jul 27, 2022
3b6e0c6
Lighten links
presleyp Jul 27, 2022
6e0b036
Lighten link just in ErrorSummary
presleyp Jul 27, 2022
6f2cfe6
Format
presleyp Jul 27, 2022
82ee773
Fix errors in schedule xservice
presleyp Jul 27, 2022
b67c1e7
Merge branch 'main' into schedule-errors/presleyp/3097
presleyp Jul 27, 2022
ce60368
Add error summary to form for generic message
presleyp Jul 27, 2022
680898f
Format
presleyp Jul 27, 2022
77df9ca
Extend getFormHelpers to remap field name
presleyp Jul 27, 2022
3e182d2
Merge branch 'main' into schedule-errors/presleyp/3097
presleyp Jul 27, 2022
a1b8f9f
Add mock error and use in storybook
presleyp Jul 28, 2022
ad871dc
Format
presleyp Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Format
  • Loading branch information
@presleyp
presleyp committed Jul 28, 2022
commit ad871dc684fbda1d76cdfd3a5f653917ff505bf8
12 changes: 6 additions & 6 deletions site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ export default {
component: WorkspaceScheduleForm,
argTypes: {
onCancel: {
action: "onCancel"
action: "onCancel",
},
onSubmit: {
action: "onSubmit"
}
}
action: "onSubmit",
},
},
}

const Template: Story<WorkspaceScheduleFormProps> = (args) => <WorkspaceScheduleForm {...args} />
Expand Down Expand Up @@ -74,6 +74,6 @@ WithError.args = {
initialTouched: { ttl: true },
submitScheduleError: makeMockApiError({
message: "Something went wrong.",
validations: [{ field: "ttl_ms", detail: "Invalid time until shutdown." }]
})
validations: [{ field: "ttl_ms", detail: "Invalid time until shutdown." }],
}),
}
4 changes: 2 additions & 2 deletions site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,15 @@ export const WorkspaceScheduleForm: FC<WorkspaceScheduleFormProps> = ({
isLoading,
onCancel,
onSubmit,
initialTouched
initialTouched,
}) => {
const styles = useStyles()

const form = useFormik<WorkspaceScheduleFormValues>({
initialValues,
onSubmit,
validationSchema,
initialTouched
initialTouched,
})
const formHelpers = getFormHelpersWithError<WorkspaceScheduleFormValues>(
form,
Expand Down
28 changes: 17 additions & 11 deletions site/src/testHelpers/entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,15 +587,21 @@ export const MockCancellationMessage = {
}

// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
export const makeMockApiError = ({ message, detail, validations }: { message?: string, detail?: string, validations?: FieldError[] }) => (
{
response: {
data: {
message: message ?? "Something went wrong.",
detail: detail ?? undefined,
validations: validations ?? undefined,
},
export const makeMockApiError = ({
message,
detail,
validations,
}: {
message?: string
detail?: string
validations?: FieldError[]
}) => ({
response: {
data: {
message: message ?? "Something went wrong.",
detail: detail ?? undefined,
validations: validations ?? undefined,
},
isAxiosError: true,
}
)
},
isAxiosError: true,
})