Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename template update to template push #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Rename template update to template push #3307

merged 2 commits into from
Jul 29, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Jul 29, 2022

Before, there was a template edit AND a template update. The
distinction between both commands was easy to forget. push more
clearly indicates that the template's source code is being updated.

It is also complimentary to existing template pull.

Before, there was a `template edit` AND a `template update`. The
distinction between both commands was easy to forget. `push` more
clearly indicates that the template's source code is being updated.

It is also complimentary to existing `template pull`.
@ammario ammario requested a review from presleyp July 29, 2022 19:06
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@ammario ammario enabled auto-merge (squash) July 29, 2022 19:17
@ammario ammario merged commit 6e63487 into main Jul 29, 2022
@ammario ammario deleted the template-push branch July 29, 2022 19:21
@sreya
Copy link
Collaborator

sreya commented Aug 1, 2022

@ammario what are you thoughts on setting an alias of update on templates push? If anyone is using the CLI in CI this is almost guaranteed to break them when they update.

@ammario
Copy link
Member Author

ammario commented Aug 1, 2022

@sreya since this software is marked as alpha with no compat guarantees I would rather avoid the bloat right now.

@ammario
Copy link
Member Author

ammario commented Aug 1, 2022

When people start complaining about us breaking things we can reconsider... but let's keep the "move fast and break things" going for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants