Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Improve shutdown procedure of ssh, portforward, wgtunnel cmds #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2022
Merged

fix: Improve shutdown procedure of ssh, portforward, wgtunnel cmds #3354

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca14871
fix: Improve shutdown procedure of ssh, portforward, wgtunnel cmds
mafredri Aug 2, 2022
ee384a2
fix: Set ssh session stderr to stderr
mafredri Aug 2, 2022
e483eef
Set stderr in ssh test to pty output
mafredri Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Set stderr in ssh test to pty output
  • Loading branch information
@mafredri
mafredri committed Aug 2, 2022
commit e483eef5980d7cff12b680d1cd162396b9f33fac
5 changes: 1 addition & 4 deletions cli/ssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ func TestSSH(t *testing.T) {
pty := ptytest.New(t)
cmd.SetIn(pty.Input())
cmd.SetOut(pty.Output())
cmd.SetErr(io.Discard)
cmd.SetErr(pty.Output())
cmdDone := tGo(t, func() {
err := cmd.ExecuteContext(ctx)
assert.NoError(t, err)
Expand All @@ -248,9 +248,6 @@ func TestSSH(t *testing.T) {

// And we're done.
pty.WriteLine("exit")
// Read output to prevent hang on macOS, see:
// https://github.com/coder/coder/issues/2122
pty.ExpectMatch("exit")
<-cmdDone
})
}
Expand Down