Conversation
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 67.61% 67.58% -0.03%
==========================================
Files 142 142
Lines 7700 7706 +6
Branches 77 77
==========================================
+ Hits 5206 5208 +2
- Misses 1966 1968 +2
- Partials 528 530 +2
Continue to review full report at Codecov.
|
jawnsy
approved these changes
Feb 20, 2022
jawnsy
left a comment
There was a problem hiding this comment.
kinda concerning to me that we're using an abandoned library, but here's not really other options (gorilla is also abandoned)
WebSockets hijack the HTTP connection from the server, causing server.Close() to not wait for these connections to fully cleanup. This adds a global wait-group to the coderd API, which ensures all WebSocket HTTP handlers have properly exited before returning.
Member
Author
|
This wasn't actually a problem with the library, but an interesting quirk with the Go HTTP library. Check the diff now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSockets hijack the HTTP connection from the server, causing
server.Close() to not wait for these connections to fully cleanup.
This adds a global wait-group to the coderd API, which ensures all
WebSocket HTTP handlers have properly exited before returning.
Closes #317