chore: Rename 'admin' to 'owner' #3498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a202178 to
fb4f80f
Compare
johnstcn
approved these changes
Aug 15, 2022
coadler
reviewed
Aug 15, 2022
| -- Update the first user with the role 'admin'. This should be the first | ||
| -- user ever, but if that user was demoted from an admin, then choose | ||
| -- the next best user. | ||
| id = (SELECT id FROM users WHERE 'admin' = ANY(rbac_roles) ORDER BY created_at ASC LIMIT 1); |
There was a problem hiding this comment.
This could technically cause the query to fail if no rows are found, I think doing id IN (...) would allow it to match no rows.
There was a problem hiding this comment.
Oh interesting. Let me try it out
There was a problem hiding this comment.
@coadler It does not seem to matter.
There was a problem hiding this comment.
Hmm, I thought this would've caused an issue when you compared a non-null field to null. Sounds good then!
Co-authored-by: Colin Adler <[email protected]>
coadler
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Admin->template-adminanduser-adminFirst user ->
owner