fix: hiding agent status on stopped workspaces #3512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
commented
Aug 15, 2022
| error = "Error", | ||
| loading = "Loading", | ||
| } | ||
|
|
There was a problem hiding this comment.
I moved this out of a component directory and into our util file so we can have properly typed statuses.
kylecarbs
approved these changes
Aug 16, 2022
jsjoeio
reviewed
Aug 16, 2022
Co-authored-by: Joe Previte <[email protected]>
Kira-Pilot
commented
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3484
We have an issue where workspace agent statuses are 'connecting' after a workspace has stopped. After chatting with @bpmct, we have decided to hide the agent status on stopped workspaces. We have also created tickets to address the agent status on the BE (see #3510 and #3511). This PR addresses hiding the status in the UI, only.
Before
After