Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Strip coder cookies from app proxy requests #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

fix: Strip coder cookies from app proxy requests #3528

merged 1 commit into from
Aug 17, 2022

Conversation

kylecarbs
Copy link
Member

Fixes coder/security#1.

@kylecarbs kylecarbs requested a review from mafredri August 16, 2022 17:41
@kylecarbs kylecarbs self-assigned this Aug 16, 2022
@kylecarbs kylecarbs changed the title fix: Strip session_token cookie from app proxy requests fix: Strip coder cookies from app proxy requests Aug 16, 2022
mafredri
mafredri approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Had a small suggestion but not critical.

@kylecarbs kylecarbs force-pushed the sessioncookie branch 2 times, most recently from e76367b to 32211df Compare August 17, 2022 14:54
@kylecarbs kylecarbs enabled auto-merge (squash) August 17, 2022 14:54
@kylecarbs kylecarbs merged commit c3f9467 into main Aug 17, 2022
@kylecarbs kylecarbs deleted the sessioncookie branch August 17, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @mafredri