Use new table formatter everywhere #3544
Conversation
There was a problem hiding this comment.
Looks great!
One thing I started thinking about. When someone filters columns or what not, can they pass in any value as long as it's close? Like say we have table:"scope id", as a user I might want to pass in -c scope_id (no quotes) or -c 'SCOPE ID' (i.e. what I see).
| err := cliui.ValidateColumns(featureColumns, columns) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
One downside of this change is that we have to round-trip to the server for a response instead of exiting immediately on bad input.
Would it make sense to expose a cliui.ValidateTableColumns([]codersdk.Derp{}, columns) function?
There was a problem hiding this comment.
I'm hoping to automate this whole process of validating columns and adding the columns/sort flags in a future PR. I just removed this because it didn't match any of the other commands, but your comment is valid. I can add it back if you want or we could wait until we have better output utilities.
There was a problem hiding this comment.
Sounds good. My opinion is that we’re not in a hurry to restore the early check. It’s a small QoL improvement but it can wait for the refactor just fine.
Yes both of those will work. |
Uses the new table formatter introduced in #3415 everywhere across the CLI except for two places:
schedule showandusers showwhich don't use a traditional table format.