feat: add cmake, nfpm to dogfood dockerfile #3558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm 🤔 69 | go install mvdan.cc/sh/v3/cmd/shfmt@latest
70 | # nfpm is used with `make build` to make release packages
71 | >>> go install github.com/goreleaser/nfpm/v2/cmd/[email protected]
72 |
73 | # Ubuntu 20.04 LTS (Focal Fossa)
--------------------
error: failed to solve: dockerfile parse error on line 71: unknown instruction: go
Error: buildx failed with: error: failed to solve: dockerfile parse error on line 71: unknown instruction: go |
johnstcn
reviewed
Aug 18, 2022
I think you're missing an |
|
Whoops! Thank you! |
kylecarbs
approved these changes
Aug 18, 2022
RUN update-alternatives --install /usr/local/bin/gofmt gofmt /usr/local/goboring/bin/gofmt 100:
#0 0.084 update-alternatives: error: alternative path /usr/local/goboring/bin/gofmt doesn't existAny ideas on this @kylecarbs ? |
This is probably my fault - I think I put this line in the wrong place 🤦 Updated to where it should probably go, and tested that the thing actually built for me. |
ef3182b to
e6c82d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
zstdwasn't found locally, I ran this script to install it. It requirescmakeso I added that to theDockerfile. I also addednfpmsince that's required formake buildand is used to embed the site.