Check AGPL code doesn't import enterprise #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <[email protected]>
deansheather
approved these changes
Aug 19, 2022
Signed-off-by: Spike Curtis <[email protected]>
f0ssel
approved these changes
Aug 19, 2022
mafredri
reviewed
Aug 19, 2022
There was a problem hiding this comment.
Looks like I was too slow with my review 😄.
Btw, I looked at the linked issue; this last comment makes it sound like it would be possible? quasilyte/go-ruleguard#78 (comment)
| cdroot | ||
|
|
||
| set +e | ||
| find . -regex ".*\.go" | grep -v "./enterprise" | xargs grep -n "github.com/coder/coder/enterprise" |
There was a problem hiding this comment.
Suggested change
| find . -regex ".*\.go" | grep -v "./enterprise" | xargs grep -n "github.com/coder/coder/enterprise" | |
| find . -name ./enterprise -prune -o -name '*.go' -print0 | xargs -0 grep -n "github.com/coder/coder/enterprise" |
Not at a computer; so can’t test. But use if you want. Silly tool optimization. This even handles spaces in names which isn’t ever going to be a problem with Go source files 🤪
|
@mafredri it is possible to match on file names, which is one requirement, but it is not possible to match the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to ensure we don't accidentally import enterprise code from AGPL code, which would cause "AGPL" builds to not really be AGPL.
Oh, and if you are wondering, "can ruleguard do this?," the answer is no