Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Support search query and --me in workspace list #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

feat: Support search query and --me in workspace list #3667

merged 1 commit into from
Aug 24, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 24, 2022

What this does

I was getting annoyed at the large list of workspaces from coder list.

Added

# All of these are equivalent if logged in as "Emyrk"
coder list --search "owner:Emyrk"
coder list --me
coder list --search "owner:me"

# Obviously other searches work
coder list --search "dev"
coder list --search owner:alice
coder list --search template:coder-ts

@Emyrk Emyrk requested a review from deansheather August 24, 2022 17:08
deansheather
deansheather approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of --me why not do --all and inverse the behavior? Most users only care about their own workspaces unless they really want to see all of them

@Emyrk
Copy link
Member Author

Emyrk commented Aug 24, 2022

Instead of --me why not do --all and inverse the behavior? Most users only care about their own workspaces unless they really want to see all of them

That's a good question 🤔. I think I will merge this because I didn't change behavior at the moment

@Emyrk Emyrk merged commit 6e49607 into main Aug 24, 2022
@Emyrk Emyrk deleted the stevenmasley/list branch August 24, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @deansheather