feat: Improve experience with local SSH keys #3835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Sep 2, 2022
cli/gitssh.go
Outdated
| "identityfile ~/.ssh/id_xmss", | ||
| }, "\n") | ||
|
|
||
| // praseIdentityFilesForHost uses ssh -G to discern what SSH keys have |
There was a problem hiding this comment.
Suggested change
| // praseIdentityFilesForHost uses ssh -G to discern what SSH keys have | |
| // parseIdentityFilesForHost uses ssh -G to discern what SSH keys have |
mafredri
commented
Sep 5, 2022
mafredri
commented
Sep 5, 2022
This change means that users can place SSH keys in the default locations for OpenSSH, like `~/.ssh/id_rsa` and it will be automatically picked up (as per a default OpenSSH experience). Fixes #3126
Co-authored-by: Dean Sheather <[email protected]>
3ef314f to
0d413fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that users can place SSH keys in the default locations for OpenSSH, like
~/.ssh/id_rsaand it will be automatically picked up (as per a default OpenSSH experience).Fixes #3126
Notes:
-test.homedirflag to test the SSH fallback key locations, however, settingHOME=/tmp/seems to have no effect on where OpenSSH looks for the config :(