Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(contributing): enable contribution via devcontainer #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

docs(contributing): enable contribution via devcontainer #3970

merged 1 commit into from
Sep 14, 2022

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Sep 9, 2022 •
edited
Loading

Related #3972

nb: I've installed nix in the devcontainer but nix is currently broken on GitHub Codespaces - NixOS/nix#6680

error: suspicious ownership or permission on '/nix/store/lb9klrhgabn5k0mwhr31ml8cnsis3rmv-addintegrityfields.js' for output 'out'; rejecting this build output
error: 1 dependencies of derivation '/nix/store/l17qv1zk3zb9ynlvlcih3y8msj75nc6x-typescript-language-server-0.11.2.drv' failed to build
error: build of '/nix/store/l17qv1zk3zb9ynlvlcih3y8msj75nc6x-typescript-language-server-0.11.2.drv', '/nix/store/l6pfwkwx7ir2qf05p0f2kjqfjvf7a4wl-protoc-gen-go-drpc.drv' failed

Apart from that LGTM. Please check to see if I missed any dependencies 👍

@ghuntley ghuntley self-assigned this Sep 9, 2022
kylecarbs
kylecarbs reviewed Sep 9, 2022
View reviewed changes
@ghuntley ghuntley force-pushed the gh/devcontainer branch 3 times, most recently from f419b71 to 6255408 Compare September 10, 2022 05:34
@ghuntley ghuntley marked this pull request as ready for review September 10, 2022 05:34
@ghuntley ghuntley added the docs Area: coder.com/docs label Sep 10, 2022
@ghuntley ghuntley enabled auto-merge (squash) September 13, 2022 03:12
@ghuntley ghuntley requested a review from kylecarbs September 13, 2022 03:13
jsjoeio
jsjoeio approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghuntley ghuntley merged commit a01ab27 into main Sep 14, 2022
@ghuntley ghuntley deleted the gh/devcontainer branch September 14, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@ghuntley ghuntley

Labels
docs Area: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghuntley @jsjoeio @kylecarbs