Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: sync autostart helpers+values when toggled #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Sep 21, 2022

Fixes #3463

previous.behavior.mov
new.behavior.mov

@bpmct bpmct requested a review from a team as a code owner September 21, 2022 03:58
@bpmct bpmct requested review from code-asher and presleyp and removed request for a team, presleyp and code-asher September 21, 2022 03:58
@presleyp
Copy link
Contributor

@ammario @Kira-Pilot I remember y'all weighing in on it being inconvenient to clear autostart/stop values when the switch is turned off. Are you okay with going back to that behavior?

@Kira-Pilot
Copy link
Member

@presleyp @bpmct I think this is fine for now. If the form gets longer, maybe we preserve user-entered values or drop a warning modal in the page.

Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems subjective which approach is best, but either behavior is fine to me.

@bpmct bpmct merged commit 9347545 into main Sep 21, 2022
@bpmct bpmct deleted the bpmct/autostart-input-fun branch September 21, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX of disabled auto-start/stop
4 participants