chore: revert open in coder docs for now #4154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
reviewed
Sep 22, 2022
bpmct
referenced
this pull request
Sep 22, 2022
* docs: add open in coder This adds new documentation for the "Open in Coder" button that admins can use to get their developers up and running faster. * fix: display error if template not found Previously, we weren't handling a case where we tried to get a template that returned a 404 from the backend. Now we handle that case in our state machine and display the error message from the API on the frontend. * feat: support template query param in index This adds support to navigate directly to a template from the index by using the `?template=<name>` query param. * Revert "feat: support template query param in index" This reverts commit bad7ffb. We decided to use the `/template/path` route instead. * fixup!: docs: add open in coder * docs: add open in coder to dogfood readme * Update docs/admin/open-in-coder.md Co-authored-by: Ben Potter <[email protected]> * Update docs/admin/open-in-coder.md Co-authored-by: Ben Potter <[email protected]> * Update docs/admin/open-in-coder.md Co-authored-by: Ben Potter <[email protected]>
kylecarbs
approved these changes
Sep 22, 2022
I got it in this PR |
jsjoeio
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided we want to add additional functionality + a new button before we document this feature.
also there were a few typos I missed