Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Remove "Starts at Manual" label #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2022
Merged

fix: Remove "Starts at Manual" label #4179

merged 2 commits into from
Oct 3, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Sep 23, 2022 •
edited
Loading

Fixes #2798 and #4303.

@kylecarbs kylecarbs self-assigned this Sep 23, 2022
@kylecarbs kylecarbs requested a review from a team as a code owner September 23, 2022 19:47
@kylecarbs kylecarbs requested review from BrunoQuaresma and removed request for a team September 23, 2022 19:47
BrunoQuaresma
BrunoQuaresma reviewed Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but we need some CSS changes when there is no label.

Screen Shot 2022-09-26 at 11 31 29

Looks like the border left is larger than the others.

BrunoQuaresma
BrunoQuaresma approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but should be good to go after it is ready. PS: Check the Storybook previews after.

@kylecarbs kylecarbs enabled auto-merge (squash) October 3, 2022 16:56
@kylecarbs kylecarbs merged commit 4f63555 into main Oct 3, 2022
@kylecarbs kylecarbs deleted the manualfix branch October 3, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Starts at Manual" is confusing
2 participants
@kylecarbs @BrunoQuaresma