Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: static error page in applications handlers #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 4, 2022
Merged

feat: static error page in applications handlers #4299

merged 6 commits into from
Oct 4, 2022

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Oct 1, 2022 •
edited
Loading

Closes #4040

  • Adds Bruno's new static error page from feat: Add static error page #4276 to most application error codepaths
  • Removes site.WithAPIResponse in favor of having the error page be the same static one for both path-based and subdomain-based applications

TODO:

  • All applications errors should use the same page, no httpapi at all
  • Remove WithAPIResponse

@deansheather deansheather marked this pull request as ready for review October 4, 2022 11:24
@deansheather deansheather requested a review from a team as a code owner October 4, 2022 11:24
@deansheather deansheather requested review from code-asher and kylecarbs and removed request for a team October 4, 2022 11:24
@deansheather deansheather requested review from Kira-Pilot and removed request for code-asher October 4, 2022 15:44
@deansheather deansheather merged commit d165d76 into main Oct 4, 2022
@deansheather deansheather deleted the dean/devurls-error branch October 4, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom proxy error page
4 participants
@deansheather @kylecarbs @Kira-Pilot @BrunoQuaresma