Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove resources calls #4344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2022
Merged

chore: remove resources calls #4344

merged 8 commits into from
Oct 3, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Oct 3, 2022

Now that the GetWorkspace call provides resources in the response there's no need for extra network calls, so we can remove these routes and usages altogether.

@f0ssel f0ssel requested a review from kylecarbs October 3, 2022 18:56
@f0ssel f0ssel marked this pull request as ready for review October 3, 2022 18:56
@f0ssel f0ssel requested a review from a team as a code owner October 3, 2022 18:56
@f0ssel f0ssel requested review from BrunoQuaresma and removed request for a team October 3, 2022 18:56
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart change. We should probably look through most of our endpoints to see what is actually used.

@f0ssel
Copy link
Contributor Author

f0ssel commented Oct 3, 2022

This is one of many PRs :)

@f0ssel f0ssel enabled auto-merge (squash) October 3, 2022 20:00
@f0ssel f0ssel merged commit 738a38d into main Oct 3, 2022
@f0ssel f0ssel deleted the f0ssel/remove-resources-calls branch October 3, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants