Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: adding gcp quickstart #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 19, 2022
Merged

Conversation

endingwithali
Copy link
Contributor

tested locallly already and ran through gramamrly

@endingwithali endingwithali requested review from ammario and bpmct October 3, 2022 20:41
@ammario ammario changed the title FEAT: adding gcp quickstart feat: adding gcp quickstart Oct 3, 2022
@endingwithali endingwithali added the docs Area: coder.com/docs label Oct 3, 2022
@ghuntley ghuntley force-pushed the endingwithali/quickstart-gcp branch from f33c8b0 to f54b959 Compare October 4, 2022 04:04
@ghuntley ghuntley force-pushed the endingwithali/quickstart-gcp branch from f54b959 to 1537f81 Compare October 4, 2022 04:05
@endingwithali endingwithali requested review from ammario and bpmct October 6, 2022 20:16
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid progress—some of my comments on the last review were left unaddressed. I didn't repeat them in this review, but plz address.

@endingwithali endingwithali requested a review from ammario October 6, 2022 22:27
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in user
and omit the double use of now.

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 15, 2022
Comment on lines +48 to +54

``` sh
sudo vim /etc/coder.d/coder.env
```

<img src="../images/quickstart/google-cloud-platform/gcp4.png">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this since the tunnel runs by default now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot removed the stale This issue is like stale bread. label Oct 18, 2022
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally missed a step. This LGTM

@endingwithali endingwithali merged commit eb04a7e into main Oct 19, 2022
@endingwithali endingwithali deleted the endingwithali/quickstart-gcp branch October 19, 2022 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants