-
Notifications
You must be signed in to change notification settings - Fork 904
feat: adding gcp quickstart #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f33c8b0
to
f54b959
Compare
f54b959
to
1537f81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid progress—some of my comments on the last review were left unaddressed. I didn't repeat them in this review, but plz address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in user
and omit the double use of now.
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
|
||
``` sh | ||
sudo vim /etc/coder.d/coder.env | ||
``` | ||
|
||
<img src="../images/quickstart/google-cloud-platform/gcp4.png"> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this since the tunnel runs by default now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally missed a step. This LGTM
tested locallly already and ran through gramamrly