not merge blocking: If a workspace had a PostgreSQL server always running in the background, would it always display here despite there being no web interface? Wondering if there might be a reason a template might want to hide ports/processes in the dropdown OR a check if something is a web app.

Also, I assume this omits ports from the coder_apps?

@bpmct

If a workspace had a PostgreSQL server always running in the background, would it always display here despite there being no web interface?

Yes, all TCP ports >= 9 will show here. Some stuff might not be a HTTP server but we don't do any HEAD requests or anything as we don't want to send data to ports without the user opting into it first.

Wondering if there might be a reason a template might want to hide ports/processes in the dropdown OR a check if something is a web app.

We should do this in a follow up.

Also, I assume this omits ports from the coder_apps?

No it doesn't but we probably could.

I find it quite odd that my workspace's code-server shows up here as node

This is mentioned in the PR description. It's because code-server runs inside of node and right now we only log the name of the process executable. I think if we filter out apps then this doesn't become that big of a problem.

I don't think we should expose this to users until we deduplicate ports from coder_app.

I will add some code server-side to filter out ports that already have apps. It should be very easy.

non-web-based ports (e.g. postgres) probably shouldn't show up here. if we don't want to add health checks, perhaps we add an option to disable ports via the template?

Sounds good to me for a follow-up. We could also have a list of ports that we filter out hardcoded, including common database ports and other common TCP protocols like SSH, FTP that have distinct port numbers. I'll do that in this PR to mitigate the issue for now.

We have some v1 users using self-signed https schemas which are rewritten. How would this be handled?

Users can make an app instead. We only support HTTP via explicit port app URLs.

@bpmct I have added backend code to filter out any ports in use by apps from the response, as well as common non-HTTP ports (like SSH, FTP, postgres etc.) as well as tests that this filtering works. You can see the list of filtered ports in agentconn.go

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

I have read the CLA Document and I hereby sign the CLA