refactor: Add 'src' folder in 'site' #445
Conversation
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
==========================================
+ Coverage 68.13% 68.17% +0.04%
==========================================
Files 158 156 -2
Lines 9224 9082 -142
Branches 73 83 +10
==========================================
- Hits 6285 6192 -93
+ Misses 2318 2291 -27
+ Partials 621 599 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Open question (did not look at files before posing): should we update our tsconfigs?
EDIT: To clarify:
- I can imagine e2e having a separate tsconfig and that our product tsconfig doesn't glob outside of
src. This sometimes means a separate tsconfig just for webpack, but that's OK.
EDIT: Another possibility is moving e2e outside of site, since it can be completely isolated. This is usually a "better" practice in terms of approaching the system as a blackbox, and not sharing anything with it.
@vapurrmaid - I don't have a strong feeling in the context of this PR, but it seems like it might be necessitated once we do the work to split out E2E in #446 . Would you be OK if we merge this as-is and then look at splitting out the tsconfigs as part splitting out E2E? |
Yea absolutely, I meant to capture that this was more of a follow-up concern, just context-attached here. I didn't mean to give an impression of it being a blocker. |
This refactoring re-organizes the
sitefolder to have a nestedsrcfolder.Originally, we wanted to keep the directory structure shallow - but there were two points that motivated this change to introduce the
srclevel.srcfolders now (e2e,static,html_templates,.storybook)srcfolder makes it easier to run XState TypegenSo given those two data points - I believe it makes sense to revisit that and introduce a
srcfolder.