Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: chrome requests hanging over port-forward #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

fix: chrome requests hanging over port-forward #4588

merged 1 commit into from
Oct 17, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Oct 17, 2022 •
edited
Loading

There was an issue where one side of the connection closing wouldn't exit the bicopy.

Fixes #3733

@coadler coadler self-assigned this Oct 17, 2022
kylecarbs
kylecarbs approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet we can re-enable the tests after this too! They probably no longer flake.

@ammario
Copy link
Member

ammario commented Oct 17, 2022

Big if fixes

@coadler
Copy link
Contributor Author

coadler commented Oct 17, 2022

huge

@coadler coadler force-pushed the colin/forward-hang branch from b98f5f7 to c343177 Compare October 17, 2022 16:18
@coadler coadler merged commit 29acd25 into main Oct 17, 2022
@coadler coadler deleted the colin/forward-hang branch October 17, 2022 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder port-forward does not work as expected. Requests are hanging
3 participants
@coadler @ammario @kylecarbs