-
Notifications
You must be signed in to change notification settings - Fork 886
feat: Redesign resources table #4600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I really like the design change, the only thing I am not sure about is that the meta data is at the top. Just thinking about a workspace that has like a lot of resources they would all show above the agent with the coder apps which are kind of the most important at least for me. I actually prefer the workspace to be at the top, that's also why I hide all of my other resources like docker volumes since they are not really "important". Another question I am asking my self is how does this redesign work with hidden resources? |
I'm glad you liked it @ntimo
It displays only the first 4 values to avoid pushing the agents too below but you can see all of them by clicking on the toggle button. Do you think it is still an issue?
I didn't understand this. By workspace do you mean the resource with agents? If yes, we changed the sort. Now, the resources are sorted by the number of agents. |
Pretty similar to the previous version. |
site/src/util/workspace.ts
Outdated
disconnected: "◍ Disconnected", | ||
connected: "Connected", | ||
connecting: "Connecting...", | ||
disconnected: "Disconnected", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good time to move these to i18n
@@ -35,6 +35,35 @@ const useHelpTooltip = () => { | |||
return helpTooltipContext | |||
} | |||
|
|||
export const HelpPopover: React.FC< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave it a shot with my kubernetes multi service template. It looks great and the "copy value" works like a charm!
- The agents are still changing order randomly. I confirmed this isn't an issue exclusive to this branch, but perhaps we should reopen Workspace page: Agents order is changing on UI endlessly #2778 if you don't want to tackle in this PR.
- The other tooltips are difficult to dismiss. I did a fix for this in Help tooltips are difficult to dismiss #4562, do we just need to rebase?
Other then that, LGTM.
I'm wondering if people with a lot of resources will not realize the logs exist or not want to scroll down to them. Maybe there could be a way to collapse all resources or skip to the logs, but that can be a future PR (if the concern is even valid, I don't know what the max number of resources will be). Also wondering about the accessibility of the version color. To me it's easier to see, but I don't know about to someone color blind or using a screen reader. Maybe the popover addresses the screen reader issue? Not sure how those are handled. Paging @Kira-Pilot Other than that, looks great! |
We have a feature to hide resources from the UI: https://coder.com/docs/coder-oss/latest/templates/resource-metadata#hiding-resources-in-the-ui
For those, I used the aria |
Demo:
Screen.Recording.2022-10-17.at.13.58.28.mov
Notable changes: