fix: agent stats websocket blocking until next interval #4609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Oct 17, 2022
For `httpapi.Heartbeat` to work properly, a call to `wsjson.Read` must always be in flight, otherwise pings can't be exchanged. This caused the ping loop to hang until the next stat interval. Since the loop was blocking until the next interval it would also never exit until it fired.
0565611 to
b3d8ab7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
httpapi.Heartbeatto work properly, a call towsjson.Readmust always be in flight, otherwise pings can't be exchanged. This caused the ping loop to hang until the next stat interval. Since the loop was blocking until the next interval it would also never exit until it fired.