Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: pluralize table names #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 17, 2022
Merged

chore: pluralize table names #463

merged 10 commits into from
Mar 17, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Mar 16, 2022 •
edited
Loading

Also populates the down migrations.

@coadler coadler self-assigned this Mar 16, 2022
@coadler coadler requested a review from kylecarbs March 16, 2022 17:46
@coadler coadler force-pushed the colin/plural-tables branch from a6d0448 to 0755398 Compare March 17, 2022 18:31
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #463 (94013f7) into main (edd8345) will increase coverage by 4.27%.
The diff coverage is 42.30%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
+ Coverage   63.72%   67.99%   +4.27%     
==========================================
  Files          74      160      +86     
  Lines         827     9278    +8451     
  Branches       79       79              
==========================================
+ Hits          527     6309    +5782     
- Misses        287     2345    +2058     
- Partials       13      624     +611
Flag Coverage Δ
unittest-go-macos-latest 62.64% <7.69%> (?)
unittest-go-ubuntu-latest 67.34% <42.30%> (?)
unittest-go-windows-2022 62.03% <7.69%> (?)
unittest-js 63.72% <ø> (ø)
Impacted Files Coverage Δ
coderd/coderd.go 96.18% <ø> (ø)
database/migrate.go 45.00% <34.78%> (ø)
coderd/coderdtest/coderdtest.go 98.87% <100.00%> (ø)
httpmw/httpmw.go 100.00% <100.00%> (ø)
codersdk/workspacebuilds.go 65.38% <0.00%> (ø)
cli/clitest/clitest.go 93.33% <0.00%> (ø)
httpmw/workspaceagent.go 47.36% <0.00%> (ø)
coderd/parameters.go 65.38% <0.00%> (ø)
codersdk/files.go 66.66% <0.00%> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd8345...94013f7. Read the comment docs.

kylecarbs
kylecarbs requested changes Mar 17, 2022
View reviewed changes
@coadler coadler requested a review from kylecarbs March 17, 2022 20:06
kylecarbs
kylecarbs approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition of the down migrations! 👇

@coadler coadler merged commit 706e60b into main Mar 17, 2022
@coadler coadler deleted the colin/plural-tables branch March 17, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @kylecarbs