Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove default namespace in k8s example #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

fix: remove default namespace in k8s example #4645

merged 1 commit into from
Oct 19, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Oct 19, 2022

Since there was a default value, a template author was never prompted. This leads to a confusing behavior if the namespace doesn't exist or the ServiceAccount does not have permissions on coder-workspaces

@bpmct bpmct requested a review from deansheather October 19, 2022 12:07
@bpmct bpmct enabled auto-merge (squash) October 19, 2022 16:26
@bpmct bpmct merged commit df39920 into main Oct 19, 2022
@bpmct bpmct deleted the bpmct/k8s01 branch October 19, 2022 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants