-
Notifications
You must be signed in to change notification settings - Fork 887
feat: paginate workspaces page #4647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
770e473
Start - still needs api call changes
presleyp 13256ce
Some xservice changes
presleyp 76071b9
Finish adding count to xservice
presleyp bdb0614
Mock out api call on frontend
presleyp 86caa80
Handle errors
presleyp 9317155
Doctor getWorkspaces
presleyp 2a8c1b3
Add types, start writing count function
presleyp f501786
Hook up route
presleyp fbcfa36
Use empty page struct
presleyp 939dcdc
Write interface and database fake
presleyp 1b142b4
SQL query
presleyp ea9f240
Fix params type
presleyp 09791c7
Missed a spot
presleyp 32168a5
Space after alert banner
presleyp 4d8e565
Fix model queries
presleyp 5eea639
Unpack query correctly
presleyp ef7f59d
Fix filter-page interaction
presleyp eae13a2
Make mobile friendly
presleyp b1ab93f
Format
presleyp fdf74aa
Test backend
presleyp 7b6e822
Fix key
presleyp 644f305
Delete unnecessary conditional
presleyp 8502b05
Add test helpers
presleyp d838789
Use limit constant
presleyp 2efe49b
Show widget with no count
presleyp 950ac50
Add test
presleyp 296281d
Format
presleyp e091841
Merge branch 'main' into paginate-ws/presleyp
presleyp 78c231d
make gen from garretts workspace idk why
f0ssel fc5df6c
fix authorize test'
f0ssel bb2f0f3
Hide widget with 0 records
presleyp 6174b4f
Fix tests
presleyp 3ab3505
Format
presleyp a20827c
Fix types generated
presleyp c06765b
Fix story
presleyp 6bd9683
Add alert banner story
presleyp de2ed63
Format
presleyp ff8cb81
Fix import
presleyp e609e5a
Format
presleyp 476019b
Try removing story
presleyp 833c1af
Merge branch 'main' into paginate-ws/presleyp
presleyp 1f62974
Revert "Fix story"
presleyp e182c19
Add counts to page view story
presleyp 8bd9afa
Revert "Try removing story"
presleyp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could probably save some code by just converting this from
database.GetWorkspaceCountParams
todatabase.GetWorkspaceParams
and then callingq.GetAuthorizedWorkspace
but completely optional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this!