refactor(site): replace UserContext with userXService #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 435/presleyp/user-state
… 435/presleyp/user-state
greyscaled
reviewed
Mar 16, 2022
There was a problem hiding this comment.
praise: I really like the pattern and removal of the user context. Very nice! I love how the projects components were greatly simplified (just red deltas) from a result of the pattern and separation of concerns.
I'm happy to ✅ this in the current state with satisfactory testing, then iterate - what are you plans @presleyp ?
presleyp
commented
Mar 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 68.12% 67.90% -0.23%
==========================================
Files 158 164 +6
Lines 9271 9309 +38
Branches 79 85 +6
==========================================
+ Hits 6316 6321 +5
- Misses 2331 2360 +29
- Partials 624 628 +4
Continue to review full report at Codecov.
|
|
Anyone know what this lint error means? 0:0 error Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: webpack.common.ts.
The file must be included in at least one of the projects provided``` |
I'm about to push a fix |
greyscaled
reviewed
Mar 18, 2022
|
@presleyp I merged #483 into your branch locally and ran everything. Tests pass, lint only fails because in this PR you need to fix two basic things:
|
greyscaled
added a commit
that referenced
this pull request
Mar 18, 2022
Summary: This is a first step in porting over v1 AuditLog in a refactored/cleaned up fashion. This isn't a direct port, since we do not yet have a UserAvatar component. Details: - Port over UserCell from v1, sans UserAvatar impl - Add tests and stories for UserCell Notes: We do not have a holistic solution for handling localization, but starting from some kind of easy way that collects/resources strings will make the migration significantly easier. It will also help out our product copy owner, @khorne3 with maintenance. An RFC regarding this might be necessitated. Impact: This change does not have any user-facing impact yet, because the UserCell is not yet rendered in the product. This enables an incremental approach to migrating in the FE of the Audit Log, which is still waiting on the BE port. Relations: - This commit relates to #472, but does not finish it. - This commit should not merge until after #465 and #483 because it's based on them.
1 task
greyscaled
approved these changes
Mar 18, 2022
greyscaled
added a commit
that referenced
this pull request
Mar 18, 2022
Summary: This is a first step in porting over v1 AuditLog in a refactored/cleaned up fashion. This isn't a direct port, since we do not yet have a UserAvatar component. Details: - Port over UserCell from v1, sans UserAvatar impl - Add tests and stories for UserCell Notes: We do not have a holistic solution for handling localization, but starting from some kind of easy way that collects/resources strings will make the migration significantly easier. It will also help out our product copy owner, @khorne3 with maintenance. An RFC regarding this might be necessitated. Impact: This change does not have any user-facing impact yet, because the UserCell is not yet rendered in the product. This enables an incremental approach to migrating in the FE of the Audit Log, which is still waiting on the BE port. Relations: - This commit relates to #472, but does not finish it. - This commit should not merge until after #465 and #483 because it's based on them.
greyscaled
pushed a commit
that referenced
this pull request
Mar 23, 2022
Summary: This is a first step in porting over v1 AuditLog in a refactored/cleaned up fashion. The existing `UserCell` component was generalized for re-use across various tables (AuditLog, Users, Orgs). Details: - Move UserCell to `components/Table/Cells` - Add tests and stories for UserCell Impact: This unblocks future work in list views like the audit log, user management panel and organizations management panel. Relations: - This commit relates to #472, but does not finish it. - This commit should not merge until after #465 and #483 because it's based on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn typegenEdit:
handlersto mock out some of our API calls, renamedmockstoentitiesbecausehandlersare another kind of mock